Skip to content

feat: support Azure managed identities#7131

Draft
matthewelwell wants to merge 1 commit intomainfrom
feat/support-azure-managed-identities
Draft

feat: support Azure managed identities#7131
matthewelwell wants to merge 1 commit intomainfrom
feat/support-azure-managed-identities

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

@matthewelwell matthewelwell commented Apr 3, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to

Please describe.

How did you test this code?

Please describe.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 3, 2026 4:37pm
flagsmith-frontend-preview Ignored Ignored Apr 3, 2026 4:37pm
flagsmith-frontend-staging Ignored Ignored Apr 3, 2026 4:37pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.35%. Comparing base (7f8e104) to head (14c921c).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7131      +/-   ##
==========================================
+ Coverage   98.34%   98.35%   +0.01%     
==========================================
  Files        1336     1336              
  Lines       50128    50733     +605     
==========================================
+ Hits        49298    49899     +601     
- Misses        830      834       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

khvn26
khvn26 reviewed Apr 3, 2026
View reviewed changes
api/app/settings/common.py
Comment on lines +180 to +182
USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH = env(
"USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH", default=False
)
Copy link
Copy Markdown
Member

@khvn26 khvn26 Apr 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's namespace it

Suggested change
USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH = env(
"USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH", default=False
)
USE_AZURE_MANAGED_IDENTITY_FOR_DB_AUTH = env(
"DJANGO_DB_USE_AZURE_MANAGED_IDENTITY", default=False
)

Plus, would be cool to signal this via the dsn somehow, e.g.

azuread+postgresql://user@server/database

@matthewelwell matthewelwell marked this pull request as ready for review April 7, 2026 13:35
@matthewelwell matthewelwell requested a review from a team as a code owner April 7, 2026 13:35
@matthewelwell matthewelwell requested review from emyller and removed request for a team April 7, 2026 13:35
claude[bot]
claude bot reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7131 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7131 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7131 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7131 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7131 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7131 Finished ✅ Results ✅

@matthewelwell matthewelwell marked this pull request as draft April 7, 2026 13:36
@matthewelwell matthewelwell removed the request for review from emyller April 7, 2026 13:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  45.6 seconds
commit  14c921c
info  🔄 Run: #15828 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  45.8 seconds
commit  14c921c
info  🔄 Run: #15828 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  57.2 seconds
commit  14c921c
info  🔄 Run: #15828 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  58.1 seconds
commit  14c921c
info  🔄 Run: #15828 (attempt 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26 khvn26 khvn26 left review comments

@claude claude[bot] claude[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewelwell @khvn26